New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MatrixCoverage{Int} a concrete type #42

Open

LilithHafner wants to merge 1 commit into adolgert:main from LilithHafner:perf

LilithHafner commented Aug 7, 2022

This PR results in a 7x performance improvement on this use case due to eliminating some runtime dispatch.

julia> @elapsed for _ in 1:30 all_pairs(rand.((30, 18, 9, 2, 6, 3, 5))...) end
6.461240745 # bfore
0.878610926 # after

See https://docs.julialang.org/en/v1/manual/performance-tips/#Avoid-fields-with-abstract-type for why this change has such a big performance impact.


          Make MatrixCoverage{Int} a concrete type

2efc50f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment