Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove i18n localization adapter #239

Open
wants to merge 3 commits into
base: v1
Choose a base branch
from

Conversation

alessandro-fazzi
Copy link
Contributor

@alessandro-fazzi alessandro-fazzi commented Dec 8, 2022

Preface

This PR is part of the plan discussed in #236

Details

  • removed LightService::I18n::LocalizationAdapter
  • removed relative specs
  • removed specific I18n configuration from spec_helper
  • LightService::Configuration.localization_adapter no more gets automatically updated based on i18n gem presence in bundle
  • README.md updated accordingly

@alessandro-fazzi alessandro-fazzi changed the base branch from v1 to main December 8, 2022 19:41
@alessandro-fazzi alessandro-fazzi changed the base branch from main to v1 December 8, 2022 19:41
@alessandro-fazzi alessandro-fazzi marked this pull request as ready for review December 8, 2022 22:35
@alessandro-fazzi
Copy link
Contributor Author

alessandro-fazzi commented Dec 8, 2022

@adomokos @gee-forr you're welcome to review.

I'm in doubt if README's documentation should be only a link to the sidecar gem's repo (https://github.com/light-service/light_service-i18n). I can see pros and cons. Opinions more than welcome - as always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant