Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export module name for use with CommonJS syntax #71

Merged
merged 1 commit into from
Mar 10, 2016
Merged

Export module name for use with CommonJS syntax #71

merged 1 commit into from
Mar 10, 2016

Conversation

craigcabrey
Copy link
Contributor

#35 added support for browserify, but it doesn't correctly export the angular module symbol. this is important when you want to require() directly in the module list:

angular
  .module('app', [
    require('angular-base64-upload')
  ]);

@kocsenc
Copy link

kocsenc commented Mar 10, 2016

👍

adonespitogo added a commit that referenced this pull request Mar 10, 2016
@adonespitogo
Merge pull request #71 from craigcabrey/master
6ee16e5 
Export module name for use with CommonJS syntax
@adonespitogo adonespitogo merged commit 6ee16e5 into adonespitogo:master Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@craigcabrey @kocsenc @adonespitogo