This repository has been archived by the owner on Apr 17, 2018. It is now read-only.
chore(scripts): rename the script to be more explicit #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current script name (`dev` & `start`) are too generic and can conflict if someone is using `npm` as a task launcher. Renaming them to `serve` & `serve:dev` is better in my opinion.
thetutlage
suggested changes
Jan 18, 2017
| @@ -3,8 +3,8 @@ | |||
| "version": "3.2.0", | |||
| "main": "server.js", | |||
| "scripts": { | |||
| "dev": "nodemon --watch app --watch bootstrap --watch config --watch .env -x node server.js", | |||
| "start": "node server.js", | |||
| "serve:dev": "nodemon --watch app --watch bootstrap --watch config --watch .env -x node server.js", | |||
There was a problem hiding this comment.
It will be nice to have fallbacks on dev and start with a warning. For example:
{
"dev": "echo \"\\033[31mWARN: 'dev' will be depreciated soon. Instead use 'npm run serve:dev'\" && npm run serve:dev"
}
|
Done 👍 |
thetutlage
approved these changes
Jan 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current script name (
dev&start) are too generic and can conflict if someone is usingnpmas a task launcher. Renaming them toserve&serve:devis better in my opinion.