Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

fix(commands): support prereleases of Node.js #114

Merged
merged 1 commit into from
Aug 1, 2018
Merged

fix(commands): support prereleases of Node.js #114

merged 1 commit into from
Aug 1, 2018

Conversation

targos
Copy link
Member

@targos targos commented Jul 31, 2018

Prereleases of Node.js such as nightly or canary releases have a
prerelease tag. Their version strings are valid semver but
semver.satisfies does not return true when compared to a regular version
number.

Refs: https://www.npmjs.com/package/semver#prerelease-tags

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

I wanted to give Adonis a try, but got blocked when I tried to create my first project:

adonis new adonis-playground
   ERROR  Unsatisfied Node.js version v11.0.0-v8-canary20180727953d5c257c. Please update Node.js to >=8.0.0 before you continue

Prereleases of Node.js such as nightly or canary releases have a
prerelease tag. Their version strings are valid semver but
semver.satisfies does not return true when compared to a regular version
number.

Refs: https://www.npmjs.com/package/semver#prerelease-tags
@coveralls
Copy link

coveralls commented Jul 31, 2018

Coverage Status

Coverage remained the same at 48.342% when pulling 4525cc5 on targos:support-node-pre into f6ec54c on adonisjs:develop.

@thetutlage
Copy link
Member

Ahh this makes sense. Thanks for contributing 😄

@thetutlage thetutlage merged commit f28cdd6 into adonisjs:develop Aug 1, 2018
@thetutlage thetutlage self-requested a review August 1, 2018 03:48
@thetutlage thetutlage assigned thetutlage and targos and unassigned thetutlage Aug 1, 2018
@thetutlage
Copy link
Member

Released as 4.0.6

@targos
Copy link
Member Author

targos commented Aug 3, 2018

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants