Allow pass query string into route helper.

[b0jia]

Proposed changes

Pass query object into route helper second argument to make query string.

Follow issue: #716

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• I have read the CONTRIBUTING doc
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works.
• I have added necessary documentation (if appropriate)

Further comments

Sample Code

route('posts.show', { id: 1, query: { foo: 'bar' } })
// => /post/1?foo=bar

<a href="{{ route('posts.show', { id: 1, query: { foo: 'bar' } }) }}">Show post</a>
<!-- href="/post/1?foo=bar" -->

[coveralls]

Coverage increased (+0.05%) to 95.382% when pulling 6633e38 on BoJiaSu:develop into 9b9c2ba on adonisjs:develop.

[thetutlage]

Can you please also open another PR for the docs?

[b0jia]

Sure, here is the document. PR#330

[RomainLanz]

Hey @BoJiaSu! 👋

Sorry for the late reply.
After some internal discussion, we think it's better to not merge this PR.

It would be better to have a new option in the third argument or add a new argument (fourth) for the query string.

The reason behind this is that query or qs could be a route parameter and therefore this would break an actual code.

[b0jia]

Hi @RomainLanz, 😀

I moved the query params to third argument.

Now, the new calling method is:

route('posts.show', { id: 1 }, {
  query: { foo: 'bar' }
});
// - or -
route('posts.show', { id: 1 }, {
  qs: { foo: 'bar' }
});
// => /post/1?foo=bar

I will update document's PR later.

[RomainLanz]

Cool! What do you think @thetutlage?

[pedro-santiago]

Quite nice! Was looking for a way to add Method Spoofing to this helper, this could be a way. Nice job @BoJiaSu !

[b0jia]

I updated document PR#330.

[jsdecena]

This is a much needed feature on the app :) 💯 🎉

[jsdecena]

🎉😍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.