Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a boolean getter to support boolean Env values #1201

Closed
wants to merge 1 commit into from
Closed

add a boolean getter to support boolean Env values #1201

wants to merge 1 commit into from

Conversation

ajoslin103
Copy link

It would be nice not to have to lookup a good method to test for Boolean

@ajoslin103
add a boolean getter to support boolean Env values
91be1ad 
It would be nice not to have to lookup a good method to test for Boolean
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 95.267% when pulling 91be1ad on ajoslin103:patch-1 into d6d0dec on adonisjs:5.0.13.

@thetutlage
Copy link
Member

There is already an RFC on env variables to improve them drastically. adonisjs/rfcs#24

@thetutlage thetutlage closed this Jul 26, 2020
@thetutlage thetutlage self-requested a review July 26, 2020 09:04
@thetutlage thetutlage added the Status: Abandoned Dropped and not into consideration label Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetutlage thetutlage Awaiting requested review from thetutlage

Assignees
No one assigned
Labels
Status: Abandoned Dropped and not into consideration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajoslin103 @coveralls @thetutlage