Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route): URL missing protocol for sub-domains #589

Closed
wants to merge 1 commit into from
Closed

fix(route): URL missing protocol for sub-domains #589

wants to merge 1 commit into from

Conversation

simontong
Copy link

@simontong simontong commented Jun 25, 2017

When executing a redirect with response.route('my-route') using domain('example.com) grouping in routes.js it will prepend the protocol to the URL.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.208% when pulling 010f348 on simontong:3.0.13 into 0fffdca on adonisjs:3.0.13.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.208% when pulling 010f348 on simontong:3.0.13 into 0fffdca on adonisjs:3.0.13.

@thetutlage
Copy link
Member

Fixed in 4.0

@thetutlage thetutlage closed this Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants