Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strategie db increment when primary key is uuid. #14

Closed

Conversation

chiaretto
Copy link

Problem

Error on strategie dbIncrement when primary key is uuid.

Solution

Change order by to filed value for best result. Now works independently of the primary key

@coveralls
Copy link

coveralls commented Jul 9, 2020

Pull Request Test Coverage Report for Build 42

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.0%

Totals Coverage Status
Change from base Build 38: -0.1%
Covered Lines: 44
Relevant Lines: 47

💛 - Coveralls

@igortrinidad
Copy link

Thanks @chiaretto

This fix for the dbIncrement strategy fixed the error 'duplicate entry' when the model has uuid primary and trying to update with one slug that already exists...

@thetutlage
Copy link
Member

The next rewrite for v5 takes inspiration for this PR handle this use case. Since, I have rewritten the entire package, it is impossible to merge this PR. :)

@thetutlage thetutlage closed this Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants