Invalid query bindings on relation belongsTo #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hasOne without null value in foreign key
thetutlage
approved these changes
Aug 25, 2017
src/Lucid/Relations/BelongsTo.js
Outdated
| @@ -32,7 +32,13 @@ class BelongsTo extends BaseRelation { | |||
| * @return {Array} | |||
| */ | |||
| mapValues (modelInstances) { | |||
| return _.map(modelInstances, (modelInstance) => modelInstance[this.primaryKey]) | |||
| const values = [] | |||
There was a problem hiding this comment.
It can be done in one line using the _.transform method of lodash. I don't like the idea of intermediate variables
There was a problem hiding this comment.
What u can do is
_.transform(modelInstances, (result, modelInstance) => {
if (modelInstance[this.primaryKey]) {
result.push(modelInstance[this.primaryKey])
}
return result
}, [])There was a problem hiding this comment.
Thx, my knowledge is small in lodash.
I will try use _.transform and send changes
thetutlage
requested changes
Aug 25, 2017
src/Lucid/Relations/BelongsTo.js
Outdated
| @@ -32,7 +32,13 @@ class BelongsTo extends BaseRelation { | |||
| * @return {Array} | |||
| */ | |||
| mapValues (modelInstances) { | |||
| return _.map(modelInstances, (modelInstance) => modelInstance[this.primaryKey]) | |||
| const values = [] | |||
There was a problem hiding this comment.
What u can do is
_.transform(modelInstances, (result, modelInstance) => {
if (modelInstance[this.primaryKey]) {
result.push(modelInstance[this.primaryKey])
}
return result
}, [])
ntvsx193
commented
Aug 25, 2017
src/Lucid/Relations/BelongsTo.js
Outdated
| @@ -32,7 +32,13 @@ class BelongsTo extends BaseRelation { | |||
| * @return {Array} | |||
| */ | |||
| mapValues (modelInstances) { | |||
| return _.map(modelInstances, (modelInstance) => modelInstance[this.primaryKey]) | |||
| const values = [] | |||
There was a problem hiding this comment.
Thx, my knowledge is small in lodash.
I will try use _.transform and send changes
thetutlage
approved these changes
Aug 25, 2017
|
This looks better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #164