Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings to trait registration #208

Merged
merged 3 commits into from
Nov 7, 2017
Merged

Add settings to trait registration #208

merged 3 commits into from
Nov 7, 2017

Conversation

benallfree
Copy link
Contributor

No description provided.

@benallfree benallfree mentioned this pull request Nov 1, 2017
Closed
@coveralls
Copy link

coveralls commented Nov 1, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 96.754% when pulling d6e321a on benallfree:trait-settings into 38587fa on adonisjs:develop.

@thetutlage
Copy link
Member

Can we please rename settings -> options. I have hardly ever used this name and never saw anyone in Node community using it :)

@benallfree
Copy link
Contributor Author

Done.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.878% when pulling 4b2c253 on benallfree:trait-settings into dfc438c on adonisjs:develop.

@thetutlage thetutlage merged commit be987ca into adonisjs:develop Nov 7, 2017
@thetutlage
Copy link
Member

BOOM 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainLanz RomainLanz RomainLanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benallfree @coveralls @thetutlage @RomainLanz