feat(Model.delete): add suport for transactions

[iam4x]

Proposed changes

Support transaction as parameter of Model.delete(trx)

Checklist

• I have read the CONTRIBUTING doc
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works.
• I have added necessary documentation (if appropriate)

[thetutlage]

We need better tests here. So everytime the delete method is called, we freeze the model to avoid any future mutations. Now, if the transaction was rollback, then we have to make sure that model instance is not in frozen state.

Feel free to ask more questions if you have.

[iam4x]

Hey @thetutlage I've pushed some "hack" in order to do that, I'm not really happy with it.

We have a fork we are using with afterTransaction lifecycle hooks where we can do this kind of stuff in a better way:

Model.addHook(
  'afterTransaction',
  (modelInstance: adonis$ModelInstance, didCommit: boolean) => {
    if (didCommit) {
      return modelInstance.isDeleted
        ? modelInstance.unsyncWithAlgolia()
        : modelInstance.syncWithAlgolia();
    }
  }
);

I will be able to re-do a PR when we will have this merged into adonis-lucid, but we are waiting for your answer on #365

For now, I think this will do 👍

[thetutlage]

I believe this will break, if I pass the same trx to multiple delete calls

[iam4x]

Yes, I'm not really happy with this (cf my comment #373 (comment)) do you have any other idea?

[thetutlage]

Closing in favor of v5