fix(config): set sameSite to false

sameSite true on chrome doesn't returns the cookies when got redirected from a different domain
adonisjs · Sep 6, 2017 · 44dfeb2 · 44dfeb2
1 parent 739a11d
commit 44dfeb2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/lib/util.js b/lib/util.js
@@ -27,7 +27,7 @@ util.getCookieOption = function (Config, keyPrefix = null) {
    */
   const options = Config.merge('session.cookie', {
     httpOnly: true,
-    sameSite: true
+    sameSite: false
   })
 
   /**

diff --git a/templates/config.mustache b/templates/config.mustache
@@ -64,7 +64,6 @@ module.exports = {
   */
   cookie: {
     httpOnly: true,
-    sameSite: true,
     path: '/'
   },
 

diff --git a/test/cookie-driver.spec.js b/test/cookie-driver.spec.js
@@ -21,7 +21,7 @@ test.group('Drivers - Cookie', () => {
   test('set default options when config is missing', (assert) => {
     const cookie = new Cookie(new Config())
     assert.isTrue(cookie._options.httpOnly)
-    assert.isTrue(cookie._options.sameSite)
+    assert.isFalse(cookie._options.sameSite)
     assert.isAbove(Date.parse(cookie._options.expires) - Date.now(), 1000 * 60 * 90)
   })
 
@@ -30,7 +30,7 @@ test.group('Drivers - Cookie', () => {
     config.set('session.age', '20 mins')
     const cookie = new Cookie(config)
     assert.isTrue(cookie._options.httpOnly)
-    assert.isTrue(cookie._options.sameSite)
+    assert.isFalse(cookie._options.sameSite)
     assert.isAbove(Date.parse(cookie._options.expires) - Date.now(), 1000 * 60 * 19)
     assert.isBelow(Date.parse(cookie._options.expires) - Date.now(), 1000 * 60 * 60)
   })
@@ -40,7 +40,7 @@ test.group('Drivers - Cookie', () => {
     config.set('session.age', 1000 * 60 * 20)
     const cookie = new Cookie(config)
     assert.isTrue(cookie._options.httpOnly)
-    assert.isTrue(cookie._options.sameSite)
+    assert.isFalse(cookie._options.sameSite)
     assert.isAbove(Date.parse(cookie._options.expires) - Date.now(), 1000 * 60 * 19)
     assert.isBelow(Date.parse(cookie._options.expires) - Date.now(), 1000 * 60 * 60)
   })