Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best place to store Ally extend code #25

Closed
damian-pf opened this issue Sep 22, 2017 · 2 comments
Closed

Best place to store Ally extend code #25

damian-pf opened this issue Sep 22, 2017 · 2 comments

Comments

@damian-pf
Copy link

Hi there,

I am working on a Slack integration that I am happy to submit to the core project once completed.

Until that point I am wondering, where is the best place to put the Ally.extendcode?

I have tried placing it in a service provider but it seemed not enough of the application was ready.
Currently it is sitting in bootstrap/http.js just before the server starts. This works but is obviously very hacky.

Thank you for your time and I look forward to contributing 😄

@thetutlage
Copy link
Member

Since you are using Adonis 3.2, you can put it inside app/Listeners/Http.js file under Http.start method.

Also if it's a new project, I recommend moving to 4.0

@thetutlage
Copy link
Member

Closing since no response from the issue reporter and not actionable as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants