Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bun support for ace add #4606

Closed
ShahriarKh opened this issue Jun 7, 2024 · 0 comments · Fixed by #4607
Closed

Bun support for ace add #4606

ShahriarKh opened this issue Jun 7, 2024 · 0 comments · Fixed by #4607

Comments

@ShahriarKh
Copy link
Contributor

Package version

6.9.1

Describe the bug

I was trying to run node ace add @adonisjs/redis, but it said:

[ error ] Invalid package manager. Must be one of npm, pnpm or yarn

However, since node ace just installs the package and provide some configurations, I think it's safe to allow bun even if the whole framework doesn't support it yet.
I changed the code manually in the node_modules and it works, but didn't do testing. I will link a draft pr below.

Reproduction repo

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant