Poll to ensure that element becomes a stylesheet #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under memory pressure or some other case, Chrome will fail to synchronously update the document.styleSheets list. This adds a polling step that confirms stylesheets are loaded correctly. Fixes adopted-ember-addons#27
Do you know what the other case(s) are? |
|
I'm going to merge this, but would love to continue this conversation. I've seen this reported in another instance here: knownasilya/ember-plupload#46 Which seems to be directly related to this ticket (albeit written in a different library) |
tim-evans
added a commit
that referenced
this pull request
Dec 9, 2015
Poll to ensure that element becomes a stylesheet
| @@ -30,6 +25,34 @@ function injectAdobeBlank() { | |||
| } | |||
There was a problem hiding this comment.
Uh oh, this should have a return true at the end or the polling will never stop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under memory pressure or some other case, Chrome will fail to synchronously update the document.styleSheets list. This adds a polling step that confirms stylesheets are loaded correctly.
Fixes #27