Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Allow global service configuration #36

Merged
merged 8 commits into from
Mar 28, 2015
Merged

[WIP] Allow global service configuration #36

merged 8 commits into from
Mar 28, 2015

Conversation

poteto
Copy link
Collaborator

@poteto poteto commented Mar 28, 2015

Taken over from #29:

Here's the first pass, as discussed.

TODO:

  • Implement the service configuration from the ENV.
  • Use the config hook to set defaults.
  • A few tests to ensure defaults are being loaded from the config.
  • Document it.

Closes #6, partially address #9. Closes #29

@poteto poteto mentioned this pull request Mar 28, 2015
Closed
4 tasks
@poteto poteto mentioned this pull request Mar 28, 2015
Merged
@poteto poteto added this to the 0.8.0 milestone Mar 28, 2015
poteto added a commit that referenced this pull request Mar 28, 2015
@poteto
Merge pull request #36 from poteto/global-service-config
9f87f42 
[WIP] Allow global service configuration
@poteto poteto merged commit 9f87f42 into develop Mar 28, 2015
@poteto poteto deleted the global-service-config branch March 28, 2015 17:03
@poteto poteto mentioned this pull request Mar 28, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@poteto @johno