Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hasBlock to has-block to avoid deprecation #363

Merged
merged 1 commit into from Jul 18, 2021

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Jul 12, 2021

I'm getting this error in one of my apps:

DEPRECATION: `hasBlock` is deprecated. Use `has-block` instead. ('ember-cli-flash/templates/components/flash-message.hbs' @ L9:C8)  [deprecation id: has-block-and-has-block-params] See https://deprecations.emberjs.com/v3.x#toc_has-block-and-has-block-params for more details.
        at logDeprecationStackTrace (/Users/peterwagenet/Development/Tilde/events-app/node_modules/ember-source/dist/ember-template-compiler.js:1984:21)
        at HANDLERS.<computed> (/Users/peterwagenet/Development/Tilde/events-app/node_modules/ember-source/dist/ember-template-compiler.js:2117:9)
        at raiseOnDeprecation (/Users/peterwagenet/Development/Tilde/events-app/node_modules/ember-source/dist/ember-template-compiler.js:2011:9)
        at HANDLERS.<computed> (/Users/peterwagenet/Development/Tilde/events-app/node_modules/ember-source/dist/ember-template-compiler.js:2117:9)
        at invoke (/Users/peterwagenet/Development/Tilde/events-app/node_modules/ember-source/dist/ember-template-compiler.js:2129:9)
        at deprecate (/Users/peterwagenet/Development/Tilde/events-app/node_modules/ember-source/dist/ember-template-compiler.js:2085:28)
        at emitDeprecationMessage (/Users/peterwagenet/Development/Tilde/events-app/node_modules/ember-source/dist/ember-template-compiler.js:19966:49)
        at PathExpression (/Users/peterwagenet/Development/Tilde/events-app/node_modules/ember-source/dist/ember-template-compiler.js:19982:13)
        at visitNode (/Users/peterwagenet/Development/Tilde/events-app/node_modules/ember-source/dist/ember-template-compiler.js:11855:16)

I'm hoping that this will help work around it.

@wagenet wagenet changed the title Change hasBlock to hasTemplate to avoid conflict Change hasBlock to has-block to avoid deprecation Jul 12, 2021
@wagenet wagenet marked this pull request as ready for review July 12, 2021 16:03
@sbatson5 sbatson5 merged commit dde3da9 into adopted-ember-addons:master Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants