New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ember to v4 #373
Upgrade ember to v4 #373
Conversation
# Conflicts: # .travis.yml # README.md # config/ember-try.js
# Conflicts: # .npmignore
import { isNone } from '@ember/utils'; | ||
|
||
export function add(...dependentKeys) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This computed wasn't used anymore
I believe this PR should have triggered a major semver update from https://github.com/ef4/ember-auto-import/blob/main/docs/upgrade-guide-2.0.md
|
Closes #371
Closes #370
@sbatson5 perhaps it makes sense to merge this one before releasing your #372 ? As you can see i've upgraded to the latest v4 but i kept all the ember-try scenarios starting from v3.12.