Convert to typescript & octane #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vlascik thanks for taking on this work! It is long overdue. I would recommend ignoring lint issues for now. It would be good to get these tests running and see if everything is passing. |
|
Gonna close this since the package is now a v2 addon! thanks @vlascik your work inspired the work that did landed! |
|
@NullVoxPopuli you know the point of this PR was to turn the code into Typescript, not v2 addon though, right? As far as I can tell the addon is still in JS. |
Yes, but everything has type declarations now! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR rewrites as much as possible to TS & Octane.
There are some TSC/ESLint errors due to FlashObject still extending EmberObject. Not sure what to do about these - if the object is rewritten as an ES6 class, subtle bugs are going to appear due to
init()vsconstructortiming, and the API will be changed (FlashObjects will have to be created withnew, instead ofEmberObject.create().I'm not entirely sure if users of this addon actually create FlashObjects on their own though - if not, and the only usage is through FlassMessages service, the change could be done and tests rewritten without much disruption to consumers.