If the contentSize is not known after the ember-native-collection is #141
+223
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also closes issue #137 |
|
+1 |
1 similar comment
|
+1 |
|
Nice addition, but will need tests before we can consider merging it. Mind doing so? |
stefanpenner
suggested changes
May 10, 2017
README.md
Outdated
| * Returns the position of the item | ||
| */ | ||
| positionAt(itemIndex, clientWidth, clientHeight) { | ||
| return { x, y}; |
There was a problem hiding this comment.
nit: funky whitespace consistency
addon/components/ember-collection.js
Outdated
| } | ||
| if (this._scrollIndex !== scrollIndexAttr && (this._clientWidth || this._clientHeight)) { |
There was a problem hiding this comment.
this area is quite complicated, it may be worth extracting to a function so it is easier to unit test.
|
I will look to it, next week.
…On Wed, May 10, 2017 at 9:10 PM Stefan Penner ***@***.***> wrote:
Nice addition, but will need tests before we can consider merging it. Mind
doing so?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#141 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGwv8iiAyOXHnZSBQPSeoJXDBYrpaiRsks5r4guIgaJpZM4L_FJa>
.
|
|
@stefanpenner do the changes @pieter-v made suffice or...? |
|
@pieter-v i'm going to roll my sleeves up and try to get this to be mergeable. My plan was to fork your branch, pull the latest changes from master and handle all conflicts then. Should I make a pr to this branch in your own forked repo so you can review/accept? |
|
@Luiz-N That is great, thanks
…On Mon, Nov 27, 2017 at 7:55 AM Luiz-N ***@***.***> wrote:
@pieter-v <https://github.com/pieter-v> i'm going to roll my sleeves up
and try to get this to be mergeable. My plan was to fork your branch, pull
the latest changes from master and handle all conflicts then. Should I make
a pr to this branch in your own forked repo so you can review/accept?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#141 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGwv8ge7_g9NLHsV6RxUzx0L05FEukshks5s6lzKgaJpZM4L_FJa>
.
|
inserted into the DOM, then retrieve it from the layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inserted into the DOM, then retrieve it from the layout
fixes issue #140