Don't keep references to cells not in the 'items' colltection #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If some items (that are currently visible) are removed from the ‘items’ collection, then they are still referenced in the _cells property. So they are still in the DMO (display: none). If afterwards these removed items are destroyed (item.destroy) and a re-rendering (e.g.: change of screen size) occurs. Then this result in an error: Assertion Failed: Cannot call writableTag after the object is destroyed. This pull request removes all cells that are not in the items collection.
raytiley
reviewed
Sep 20, 2017
| @@ -187,11 +188,11 @@ export default Ember.Component.extend({ | |||
| set(cell, 'hidden', false); | |||
| cellMap[itemKey] = cell; | |||
| } else { | |||
| set(cell, 'hidden', true); | |||
| set(cell, 'style', 'height: 0; display: none;'); | |||
| cellsToDelete.push(cell); | |||
There was a problem hiding this comment.
It's been so long but keeping the cell around might have some performance wins if the collection shrinks, but then grows again ( you don't have to pay to re-create the DOM the second time). Rather than deleting the cell could we instead just set item to null?
There was a problem hiding this comment.
Sorry for the delay.
Setting the item to null, solves the problem of keeping a reference to not used items.
But it introduces another problem: the component that is used to render the item should be able to handle 'null'-items.
This moves extra complexity to yield block. So, I think it is better to loose some performance in the shrink-grow scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some items (that are currently visible) are removed from the
‘items’ collection, then they are still referenced in the _cells
property. So they are still in the DOM (display: none).
If afterwards these removed items are destroyed (item.destroy) and a re-rendering
(e.g.: change of screen size) occurs. Then this result in an error:
Assertion Failed: Cannot call writableTag after the object is destroyed.
This pull request removes all cells that are not in the items
collection.