Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number validator? #60

Closed
dzbo opened this issue Oct 23, 2015 · 3 comments
Closed

Number validator? #60

dzbo opened this issue Oct 23, 2015 · 3 comments

Comments

@dzbo
Copy link

dzbo commented Oct 23, 2015

I can't locate number validator neither in code nor in the docs. I see there is message for that https://github.com/offirgolan/ember-cp-validations/blob/master/addon/validators/messages.js#L78. Should I create custom one then?
@offirgolan
Copy link
Collaborator

My goal was to be able to replace the number validator with the inclusion/exclusion validators since they are type checked. If this isnt enough, just use a custom validator for now. If there is a need for a number validator we can create one later down the line.

@dzbo
Copy link
Author

dzbo commented Oct 23, 2015

Yep, I've created my own number validator for now. But yea, it would be great to have one built in, it's rather common.

offirgolan pushed a commit that referenced this issue Oct 26, 2015
number validator
61eecd6 
I initially thought this can be replaced by type checked
inclusion/exclusion but there are way too many specific use cases.

This should also suffice #60
@offirgolan offirgolan mentioned this issue Oct 26, 2015
Merged
@offirgolan
Copy link
Collaborator

Please upgrade to 2.1.0 and check out the number validator docs 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@offirgolan @dzbo