Adding additional date validation options.

[aaronbhansen]

I needed some additional date validation checks. Rather than write a custom validator, I figured I would create a pull request adding the functionality.

This adds two new date validation options:

beforeOrSame
afterOrSame

Also added a precision quantifier so that if you are passing full dates in from ember data or another source you could quantify what to compare on. For example, you could limit the precision to 'day' to ignore any time differences.

[offirgolan]

This is fantastic! The one thing I dont like is the OrSame postfix. What do you think of using OrOn instead?

• beforeOrOn
• afterOrOn

[aaronbhansen]

I have no preference, I was just copying moment js method name format. I updated the code to OrOn format.

[offirgolan]

Okay you might hate be but can you change it to onOrBefore and onOrAfter? Ill merge after. Just think it sounds better tbh. 😸

[aaronbhansen]

I can change it, one thing I did like about beforeOrOn / afterOrOn, is that if your validators were previously before / after, it was less work / error prone to change to beforeOrOn or afterOrOn by just appending onto the end. If you still want it changed after that input I'll do it. Let me know.

[offirgolan]

True, but doing a simple find/replace from before to onOrBefore is not too hard 😜. Honestly, its more of it will bother me later if we dont do it now kinda thing lol

[aaronbhansen]

Its changed

[offirgolan]

👍 Thanks for dealing with my antics! Ill merge once the build passes.

[aaronbhansen]

No problem. Glad to help out

[offirgolan]

Im sorry, just for clarification, is the default precision in moment seconds? If you just pass moment().isAfter(date) is the precision assumed to be in seconds?

[aaronbhansen]

In moment js the default is milliseconds as seen here We could add that option, but it seemed far more granular than a validation would ever need.

[offirgolan]

I don't think that we should actually default the precision. I'm assuming
that if you pass undefined, it should just use moment's default.

On Saturday, April 16, 2016, Aaron Hansen notifications@github.com wrote:

In moment js the default is milliseconds as seen here
https://github.com/moment/moment/blob/2749f08a24056f93dd2208f2744f21b35f6cd999/src/lib/moment/compare.js#L11
We could add that option, but it seemed far more granular than a validation
would ever need.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#168 (comment)

Thanks,
Offir Golan

[aaronbhansen]

I removed the default precision. I didn't list milliseconds as an option, since thats what it internally defaults to anyway if we don't pass it in.

[offirgolan]

This line isn't needed here because the options object is already a new pojo created from processOptions method. You can also remove the const assign declaration from the top.

[aaronbhansen]

Yep your right, I thought it shouldn't need it. The tests are mutating the options because processOptions isn't called. I need to clone the object in the tests. I'll get that fixed.

[aaronbhansen]

Made the changes, let me know if you want anything else done.

[offirgolan]

👍 Thanks for taking the time to make all those changes @aaronbhansen!

[aaronbhansen]

No problem, glad to help out. Next pull request I'll know what you're looking for more 😄