Updated ember required and ember validators packages

[kprasadpvv]

Resolves #

• To get the updated version of ember-cli-babel which is causing depreciation warnings

Changes proposed:

• Updating ember-validators as it's current version is already having updated babel version

Tasks:

• Added test case(s)
• Updated documentation

[kprasadpvv]

@fsmanuel could you please review the PR

[fsmanuel]

@kprasadpvv Looks good to me but I have some concerns how we release it. I opend a issue to discuss this: #716
Happy to get your input.

[fsmanuel]

We need to include the breaking changes in the changelog. See my review comment.

[kprasadpvv]

Hi @fsmanuel,
can we release these dependencies update as v4.0.0-beta.13 and release 4.0 after addressing #714
(or)
These dependency changes should also be done as a part of release 4.0 ?

[fsmanuel]

I think we should use the fact that the addon is in beta so we can add the breaking changes in a 4.0 release. I hope it's not too painful. Can you rebase and add a 4.0.0 entry to the changelog and add the following changes:

Breaking changes from ember-validators

• removed custom String 'now' argument.
• remove momentjs
• Remove precision argument. If you need to compare based on precision, you can use the Intl.DateTimeFormat APIs to hone in on the comparison - { year: 'numeric' }
• Added locale option. Defaults to en-us when creating date times using Intl.DateTimeFormat API.

[kprasadpvv]

Thank you @fsmanuel , I've update as per the above comment.
Please have a look and let me know if anything needs to be done.

[fsmanuel]

@NullVoxPopuli would you be so kind and approve the github actions:
https://github.com/adopted-ember-addons/ember-cp-validations/actions/runs/2621043171

[kprasadpvv]

@NullVoxPopuli would you be so kind and approve the github actions: https://github.com/adopted-ember-addons/ember-cp-validations/actions/runs/2621043171

@NullVoxPopuli , could you please approve again for git actions to run as I fixed the failing test cases. Thank you in advance.

[MelSumner]

Approach:

The idea is to have a new beta release for ember versions < 4.0 so the tests for ember-4.0, release, beta, and canary are expected to fail. After the beta release we can start to make it work for ember 4.0 (remove old/private imports, etc)

The relevant tests for this approach pass, so I'm approving this PR.

[fsmanuel]

@MelSumner Thanks!