Replace require with @embroider/macros fixing embroider support #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achambers
force-pushed
the
remove-require
branch
from
d86a777
to
a46390f
Compare
In order to place nicely with Embroider, we need to remove window.require. Instead we can use `dependencySatisfies` and `importSync`.
achambers
force-pushed
the
remove-require
branch
from
a46390f
to
57b2d2b
Compare
|
@achambers Awesome! |
|
@achambers is this also possible for |
mansona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to place nicely with Embroider, we need to remove
require. Instead we can usedependencySatisfiesandimportSync.Resolves #740
Changes proposed:
requireand replace withdependencySatisfiesandimportSync. (docs)Tasks:
N/A