Bump pretender to 3.4.3

[jcardali]

See #427

[jcardali]

@patocallaghan @danielspaniel

[patocallaghan]

Thanks @jcardali. Although I'm not sure if it's so straightforward. It appears @herzzanu had issues before when bumping the minor version of pretender.js in #387. @herzzanu is there an easy way to replicate this error so we can figure out if upgrading pretender.js works?

[herzzanu]

Why not ~3.4.3 ?

[patocallaghan]

Because using ^ says we should be able to use all Pretender versions up until 4.0.0 rather than ~ which will only allow up until 3.5.0. As Pretender uses semver there shouldn't be any breaking changes until 4.0. Also all the other dependencies use ^.

[herzzanu]

I know but remember this is how we solved #387. What I suggested would help keep it "under control". We can intervene and bump the version again if needed anyway. WDYT?

[herzzanu]

Also same fix here previously #354

[patocallaghan]

@herzzanu I'd prefer to leave it with ^ as I think it's better to have looser dependencies for consuming apps. Mirage.js also uses pretender with ^. I know there's been issues in the past with stability but I do seem to remember there was a large chunk of refactoring happening at that time (they were introducing fetch into Pretender) and it appears things are a lot more stable now.

[herzzanu]

Sounds good to me 👍

[herzzanu]

Thanks @jcardali. Although I'm not sure if it's so straightforward. It appears @herzzanu had issues before when bumping the minor version of pretender.js in #387. @herzzanu is there an easy way to replicate this error so we can figure out if upgrading pretender.js works?

@jcardali @patocallaghan I guess testing this updated version in an ember app should tell the truth if it's ok or not.

[patocallaghan]

Thanks @herzzanu, I'll try it out in a new ember app. I just thought you'd come across something specific to make the bug occur 👍

[patocallaghan]

@jcardali any chance you could regenerate the yarn.lock file with this dependency update please?

[patocallaghan]

@jcardali it looks like your using an internal registry here which is causing CI to fail

[jcardali]

@patocallaghan Sorry about that, fixed now

[patocallaghan]

Thanks @jcardali 🙌 Released in v3.9.8