Change import of deprecate from @ember/application/deprecations to @ember/debug #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mber/debug. The existing import is preventing apps upgrading to Ember 4 due to a missing module error. As deprecate is available in @ember/debug in v3.28 this should be safe to change.
|
Thanks @colinfkennedy 🙇♂️ Have some failing tests but they're unrelated to your changes. Will merge your fixes anyway. |
patocallaghan
pushed a commit
to patocallaghan/ember-data-factory-guy
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing import is preventing apps upgrading to Ember 4 due to a missing module error.
The module
@ember/application/deprecationsno longer exists in Ember 4.As the
deprecatefunction is available in@ember/debugin Emberv3.28(Current Ember version for ember-data-factory-guy) and Emberv4.0.0this should be safe to change.I have tested this locally with my own Ember 4 app.