Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of deprecations #461

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions config/deprecation-workflow.js

This file was deleted.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"ember-source": "~3.28.0",
"ember-source-channel-url": "^3.0.0",
"ember-template-lint": "^3.6.0",
"ember-test-selectors": "^5.0.0",
"ember-test-selectors": "^6.0.0",
"ember-try": "^1.4.0",
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.3.0",
Expand Down
4 changes: 3 additions & 1 deletion tests/dummy/app/controllers/search.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import Controller from '@ember/controller';
import { inject as service } from '@ember/service';

export default Controller.extend({
router: service(),
actions: {
userSearch(name) {
this.transitionToRoute('search.results', name);
this.router.transitionTo('search.results', name);
},
},
});
2 changes: 2 additions & 0 deletions tests/dummy/app/controllers/user.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import Controller from '@ember/controller';
import { inject as service } from '@ember/service';
export default Controller.extend({
store: service(),
actions: {
createProject(user, title) {
return this.store
Expand Down
2 changes: 1 addition & 1 deletion tests/dummy/app/templates/components/single-user.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ Projects:
{{/each}}
</ul>

<label>Project title{{input class="project-title" type="textbox" value=this.projectTitle}}</label>
<label>Project titl<Input class="project-title" @type="textbox" @value={{this.projectTitle}} /></label>
<button class="add-project" type="button" {{action 'addProject' user projectTitle}}>Add Project</button>
2 changes: 1 addition & 1 deletion tests/dummy/app/templates/components/user-search.hbs
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div>Search For User:</div>
<label>Username: {{input class="user-name" type="textbox" value=this.userName}}</label>
<label>Username: <Input class="user-name" @type="textbox" @value={{this.userName}} /></label>
<button class="find-user" type="button" {{action "findUsers" userName}}>Go</button>
16 changes: 16 additions & 0 deletions tests/dummy/config/deprecation-workflow.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict';
/* global self */

self.deprecationWorkflow = self.deprecationWorkflow || {};
self.deprecationWorkflow.config = {
workflow: [
{ handler: 'silence', matchId: 'deprecate-fetch-ember-data-support' },
{
handler: 'silence',
matchId: 'deprecated-run-loop-and-computed-dot-access',
},
{ handler: 'silence', matchId: 'ember-source.deprecation-without-for' },
{ handler: 'silence', matchId: 'ember-source.deprecation-without-since' },
{ handler: 'silence', matchId: 'this-property-fallback' },
],
};
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5491,10 +5491,10 @@ ember-template-recast@^5.0.3:
tmp "^0.2.1"
workerpool "^6.1.4"

ember-test-selectors@^5.0.0:
version "5.5.0"
resolved "https://registry.yarnpkg.com/ember-test-selectors/-/ember-test-selectors-5.5.0.tgz#114bd29c4a33eee3a328c9ce32a57a018c27f5f6"
integrity sha512-PiKhbPnidRYQ5ed/CTU3teJV3XmzkjYjsCGx1UTy7qEY/1dEqxezlZu1DtisoLJ9Y+BcjTVlE+596lo9cOXd3w==
ember-test-selectors@^6.0.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/ember-test-selectors/-/ember-test-selectors-6.0.0.tgz#ba9bb19550d9dec6e4037d86d2b13c2cfd329341"
integrity sha512-PgYcI9PeNvtKaF0QncxfbS68olMYM1idwuI8v/WxsjOGqUx5bmsu6V17vy/d9hX4mwmjgsBhEghrVasGSuaIgw==
dependencies:
calculate-cache-key-for-tree "^2.0.0"
ember-cli-babel "^7.26.4"
Expand Down