-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove hard dependency on model-fragments #468
fix: remove hard dependency on model-fragments #468
Conversation
Hi @luxferresum and thanks for the fix!
TaskTemplate is one our models. I added the following changes here https://github.com/MakeMusicInc/ember-data-factory-guy/commit/30cb1233111534376abfae08b3bfb205f43c3eb1 |
@luxferresum yep we should fix this. If you can apply the fixes @GabrielCousin suggests I'll merge and do a new release |
@patocallaghan I merged the other commit. |
Great, thanks I'll follow up this evening 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luxferresum looks like you have a lint error. I think we need to import require
like in addon/factory-guy.js
30cb123
to
8a92759
Compare
Thanks @luxferresum and @GabrielCousin 🙌 |
Released in 3.9.11 |
using factory guy without model-fragments results in errors (at least on ember 4.4). this should fix this.