-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail when running tests with codecoverage enabled within electron #259
Comments
I'm getting this same issue, but not on ember-electron specifically but rather on the tests for an ember addon (found this via google search). I'm stuck on it, and I've found nothing helpful on the internet. I have figured out that it has nothing to do with that last test, and rather it's something to do with shutting down the test environment. It only happens for me on 2.12 and up. 2.8 LTS runs fine. Did you figure anything out about it @kevingelion? |
I'm hitting this as well. |
ember-cli-code-coverage/ember-cli-code-coverage#75 |
Ok, I got code coverage up and running. First, I had to change require to requireModule because ember-electron overwrites Then I created an express app to fill in for the middleware because ember-electron intercepts the middleware route, https://gist.github.com/xn/d9d71acb3af59eb90d921ecdf8e738e0 @jkeen @kevingelion |
I believe it is, yes. |
Thanks @xn. Can you please open an issue + link to this one in e-cli-code-coverage? I see how we can move your fix upstream, but not knowing that project's guts would like to discuss exactly how with @kategengler first. (Plus, I think it'd be nicer for her to hear from an actual user directly :) |
Sure thing, will do. |
FWIW, this is still happening. Steps to repro:
That first error comes from this line since Upgrading to the beta version via
I'm not sure exactly what's going on here, but it may have something to do with our customer |
@jacobq Did you see my work around above? |
Yes, @xn, I saw that you were able to get it working, but it looked like you had to modify code. I think the goal of this issue is to avoid needing to fork/modify anything to get it to work, and I wanted to see if that had been done yet. |
Ah, that would be contingent on getting that |
The |
I'm using
ember-cli-code-coverage
and runningCOVERAGE=true ember electron:test
but my tests fail:Running
ember electron:test
works fine so I'm not sure what's happening. I know this might not be related to ember-electron, however, was curious when I saw it looking atserve://dist/
.The text was updated successfully, but these errors were encountered: