Run blueprint manually #1052
Merged
Run blueprint manually #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately #1048 wasn't a full fix because `electron-forge` also has a dependency on `chalk`, so even without our own dependency, installing `ember-electron` could cause the hoisting to change triggering the underlying issue (ember-cli/ember-cli#7431). So, until that issue in `ember-cli` can be addressed, we're no longer running the blueprint automatically. Instead, we point the default blueprint at a new one that simply prints out instructions telling the user to run `ember g ember-electron` manually.
bendemboski
force-pushed
the
run-blueprint-manually
branch
from
6811621
to
23077ab
Compare
|
@rwwagner90 I think this is our solution for now. I created a new branch off of this and cherry-picked your ember-cli 4.1 commits, and it passes. So my proposal is we do this for now, i.e. instruct users to run the blueprint manually, until ember-cli/ember-cli#7431 is addressed. Let me know what you think. |
RobbieTheWagner
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately #1048 wasn't a full fix because
electron-forgealso has a dependency onchalk, so even without our own dependency, installingember-electroncould cause the hoisting to change triggering the underlying issue (ember-cli/ember-cli#7431).So, until that issue in
ember-clican be addressed, we're no longer running the blueprint automatically. Instead, we point the default blueprint at a new one that simply prints out instructions telling the user to runember g ember-electronmanually.