Deprecate FileUpload component and FileDropzone attribute args
#706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilest
commented
Feb 22, 2022
| @@ -129,6 +141,77 @@ export default class FileDropzoneComponent extends Component<FileDropzoneArgs> { | |||
| window.document && | |||
| 'draggable' in document.createElement('span'))(); | |||
|
|
|||
| constructor(owner: unknown, args: FileDropzoneArgs) { | |||
There was a problem hiding this comment.
Is checking args in the constructor the best way to do this?
gilest
commented
Feb 22, 2022
Comment on lines
102
to
111
| deprecate( | ||
| `\`<FileUpload>\` is deprecated. Use \`{{file-queue}}\` helper with \`{{queue.selectFile}}\` modifier.`, | ||
| false, | ||
| { | ||
| for: 'ember-file-upload', | ||
| id: 'file-upload', | ||
| since: { enabled: 'v5.0.0' }, | ||
| until: 'v6.0.0', | ||
| } | ||
| ); |
There was a problem hiding this comment.
There's a lot of deprecated arguments also – but I figured a single deprecation warning with a (soon to be added) link to good upgrade docs is the best way forward here.
gilest
commented
Feb 22, 2022
Comment on lines
+39
to
+46
| /** | ||
| * Whether to add multiple files to the queue at once. | ||
| * | ||
| * If set to false only one file will be added when dropping mulitple files. | ||
| * | ||
| * @defaultValue true | ||
| */ | ||
| multiple?: boolean; |
There was a problem hiding this comment.
Decided not to deprecate as I can't think of an easy way to suggest a user implementation of the same feature.
gilest
changed the title
<FIleUpload> component and <FileDropzone> args
gilest
changed the title
<FIleUpload> component and <FileDropzone> args<FileUpload> component and <FileDropzone> args
gilest
force-pushed
the
register-deprecations
branch
from
acfb333
to
26fc2e3
Compare
Deploying with
|
| Latest commit: |
deacc16
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e3ef4ec4.ember-file-upload.pages.dev |
gilest
changed the title
<FileUpload> component and <FileDropzone> argsFileUpload component and FileDropzone attribute args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register all v5 deprecations until v6. This includes the entire
FileUploadcomponent.