Convert HttpRequest and upload() to typescript #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
bb0b8d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e5a30e7e.ember-file-upload.pages.dev |
gilest
changed the title
gilest
force-pushed
the
refactor/system-types
branch
from
bb0b8d3
to
f789645
Compare
|
Hi @gilest! Huge thanks for the v5 release, we tested it recently and it works perfectly :) Any chance you could release this TS changes? It's the last blocker before we could use the new version <3 |
|
@GabrielCousin I have just released Let me know how it works for you – I'm not an expert in typescript, especially publishing an addon using it. |
|
@gilest Thanks for the release! On one hand, it solves existing issues, on the other hand, it brings new TS errors 😢 I will do my best with opening a PR shortly, if that sounds good to you. |
|
That's a shame. Would welcome a PR or issue detailing the problems you're having |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #650 and to simplify the upcoming v2 build