Refactor queued files autotracking test #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
dcacd36
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://55716c7e.ember-file-upload.pages.dev |
gilest
force-pushed
the
chore/unskip-test
branch
2 times, most recently
from
18addfa
to
c48e6bf
Compare
I've repalced the mirage handler due to complexity and some new timing change in a dependency which makes this test unreliable. Refactored to mock the state change of the file via a simulated upload. This isolates the part we actually want to test here – tracking of files in queues.
gilest
changed the title
gilest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test temporarily disabled in 519f6a9 as there's a hard to isolate timing change in a dependency which was making it fail in some matrix builds.
Refactored to mock the state change of the file via a simulated upload rather than using the mirage handler. This isolates the part we actually want to test here – tracking of files in queues.