Listen for drag-and-drop events on the Dropzone element rather than document #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… node rather than document.body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think I was able to reproduce the reported issue using a regression test.
Refactored
DragListenerto attach and remove all events from the Dropzone element itself.In the pre-Octane design there was a global
DragListener. This would be more efficient for a page with many Dropzones and could be addressed in a further refactor. For now though, this does not change performance, and hopefully fixes the reported issue (Fixes #446).Also replaced some
thiscontext binding with the action decorator as I'm not sure the event listener removal was using the same functions as the event listener addition.