Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ember-modifier resolution path #962

Merged
merged 1 commit into from Jul 22, 2023
Merged

Conversation

gilest
Copy link
Collaborator

@gilest gilest commented Jul 21, 2023

It seems that rolling back the internal version fixes #957 in the addon output.

Shouldn't affect the supported versions of ember-modifier.

Why this affects the build output, I'm not sure, it may be

  • our modifier declaration is incorrect in some way
  • out typscript configuration is incorrect in some way (not at all unlikely)
  • a bug in ember-modifier for which an issue needs to be filed

@gilest gilest added the bug label Jul 21, 2023
@gilest gilest changed the title Fix ember-modifier require path by reverting internal version Fix ember-modifier import by reverting internal version Jul 21, 2023
@gilest gilest changed the title Fix ember-modifier import by reverting internal version Fix ember-modifier resolution path by reverting internal version Jul 22, 2023
@gilest gilest changed the title Fix ember-modifier resolution path by reverting internal version Fix ember-modifier resolution path Jul 22, 2023
@gilest gilest merged commit c477b61 into master Jul 22, 2023
12 checks passed
@gilest gilest deleted the fix/ember-modifier-types branch July 22, 2023 06:52
@gilest gilest mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPM bundle ember-file-upload@8.1.0 is broken
1 participant