Add afterInfinityModel #105
Conversation
davidgoli
force-pushed
the
after-infinity
branch
5 times, most recently
from
bbd74f4
to
343f6a7
Compare
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "ember-infinity", | |||
| "version": "0.2.0-beta.1", | |||
| "version": "0.2.0", | |||
There was a problem hiding this comment.
We usually bump the version separate to a PR @davidgoli - can you please remove this file from the PR?
| } | ||
| }, | ||
| afterInfinityModel(items) { | ||
| return items.setEach('author', 'F. Scott Fitzgerald'); |
There was a problem hiding this comment.
Hm, this test doesn't actually test that - in fact it's identical to the test above.
There was a problem hiding this comment.
I don't think this is a feature we need first-order support for anyways.
There was a problem hiding this comment.
We can implement that separately.
There was a problem hiding this comment.
NM this is supported, it's just that test wasn't testing it
davidgoli
force-pushed
the
after-infinity
branch
2 times, most recently
from
c4a3076
to
d22dcf3
Compare
davidgoli
force-pushed
the
after-infinity
branch
from
d22dcf3
to
33d9105
Compare
|
@hhff updated! |
|
awesome work @kxcrl & @davidgoli - I'm doing a lightning talk at EmberNYC next week - going to be showing off this awesome feature 👍 |
|
@hhff Awesome! Good luck! |
|
Hello! I'm having duplicated results on latest 0.2.1 model() {
return this.infinityModel('wall/event', {
perPage: 6,
startingPage: 0,
q:'relevant'
});
}Cheers! |
This supercedes #77 with all changes made.