InfinityModels managed by service + closure actions #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
changed the title
snewcomer
force-pushed
the
sn/component-loading
branch
from
61f91a7
to
6c47ef6
Compare
snewcomer
changed the title
snewcomer
force-pushed
the
sn/component-loading
branch
from
e64f6a1
to
f197faa
Compare
snewcomer
force-pushed
the
sn/component-loading
branch
2 times, most recently
from
a3fbe57
to
f000062
Compare
snewcomer
force-pushed
the
sn/component-loading
branch
from
f000062
to
d6e9e2a
Compare
snewcomer
commented
Apr 7, 2018
| Lastly, by default, ember-infinity expects the server response to contain something about how many total pages it can expect to fetch. `ember-infinity` defaults to looking for something like `meta: { total_pages: 20 }` in your response. See [Advanced Usage](#AdvancedUsage). | ||
|
|
||
|
|
||
| ### Closure Actions<a name="ClosureActions"></a> |
| this.sendAction('loadPreviousAction', infinityModelContent, -1); | ||
| if (typeof(get(this, 'infinityLoad')) === 'function') { | ||
| // closure action | ||
| return get(this, 'infinityLoad')(infinityModelContent, -1); |
There was a problem hiding this comment.
new api for infinity-loader
| } else { | ||
| return true; | ||
| } | ||
| } | ||
| }, | ||
|
|
||
| /** | ||
| @private |
There was a problem hiding this comment.
move all logic to service
| @@ -33,6 +33,7 @@ | |||
| "ember-cli-htmlbars": "^2.0.1", | |||
| "ember-cli-htmlbars-inline-precompile": "^1.0.0", | |||
| "ember-cli-inject-live-reload": "^1.4.1", | |||
| "ember-cli-mirage": "^0.4.3", | |||
There was a problem hiding this comment.
Haven't replaced all instances, but plan on fixing these over time.
| @@ -0,0 +1,143 @@ | |||
| import { module, test } from 'qunit'; | |||
There was a problem hiding this comment.
replace test (offset-trigger) with general acceptance test
| {{infinity-loader | ||
| infinityModel=model | ||
| infinityLoad=(action loadMorePosts) | ||
| infinityLoadPrevious=(action loadMorePostsPrevious) |
There was a problem hiding this comment.
examples using closure actions
| infinityModel.replace(0, len, []); | ||
| return infinityModel; | ||
| } | ||
| }, |
There was a problem hiding this comment.
replace, flush, pushObjects, unshiftObjects. Not sure about having the same API as Ember though for pushObjects/unshiftObjects. Thoughts?
snewcomer
commented
Apr 11, 2018
| }; | ||
|
|
||
| let convertToArray = (queryObject) => { | ||
| if (queryObject.toArray) { |
There was a problem hiding this comment.
Could also add if not an array, but an object, then make an array
This was referenced Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InfinityModels managed by a service to provide an API to update, filter, set the list of infinityModels. Moreover, instead of bubbling actions to the route, this opens up the possibility for closure actions.
replace,flush,pushObjects, andunshiftObjectsmethodsinfinity-loadercomponent to accept a closure actionOne of the big benefits of closure actions is the ability to return a value or curry values; and although we don't necessarily need those in this example, I can see it useful for others.
Ref #272 #270
Will open up possibilities for #275