Upgrade to Ember 5 and convert to a v2 addon #470

wozny1989 · 2023-06-03T07:53:51Z

Tasks

Update all packages and Ember to version 5.8, support for >= 3.28
Migrate to addon v2
Fix error with content or passed custom params:

Uncaught Error: Assertion Failed: You attempted to update `perPageParam` on `<InfinityModel:ember129>`, but it had already been used previously in the same computation.  Attempting to update a value after using it in a computation can cause logical errors, infinite revalidation bugs, and performance issues, and is not supported.

ndekeister-us · 2023-11-04T19:19:53Z

Ping @snewcomer any chance we can have checks running for this PR? (and if they are passing, to have this PR merged)

Ember 5 is coming and we will need some changes in this project, I believe this PR is a good start (and in fact may be enough to have the compatibility with Ember 5)

jahrock · 2023-12-14T07:13:00Z

Hi @snewcomer & @hhff
We would be very grateful if you could take the time to look at the PR.

hhff · 2024-03-28T21:03:36Z

Hi @jahrock - it's been a long time since I worked on Ember. @snewcomer - what do you think?

jahrock · 2024-04-02T19:17:33Z

Hi @hhff
Thanks for your feedback.
Would it be an option for you to transfer the addon ownership to "adopted ember addons" so that interested developers can get involved?

The effort is quite low and can be achieved through the linked process.
https://github.com/adopted-ember-addons/program-guidelines/blob/master/README.md

hhff · 2024-04-02T19:34:05Z

Yes, absolutely. Let me look into this and I'll get back to you!

…

On Tue, Apr 2, 2024 at 3:17 PM Jah Rock ***@***.***> wrote: Hi @hhff <https://github.com/hhff> Thanks for your feedback. Would it be an option for you to transfer the addon ownership to "adopted ember addons" so that interested developers can get involved? The effort is quite low and can be achieved through the linked process. https://github.com/adopted-ember-addons/program-guidelines/blob/master/README.md — Reply to this email directly, view it on GitHub <#470 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAV3R7CHLSD2W45PZNKEMQDY3L76JAVCNFSM6AAAAAAYZELAGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSHA4TGNZQGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *Hugh Francis* c/o Sanctuary Computer, Inc 120 Walker, FL3 New York, NY 10013 sanctuary.computer <https://www.sanctuary.computer>

jahrock · 2024-04-10T10:42:42Z

Hi @hhff
You can transfer the github repository to @RobbieTheWagner. Keep in mind to provide him access to npm.js as well.

RobbieTheWagner · 2024-04-10T13:44:39Z

Hi @hhff You can transfer the github repository to @RobbieTheWagner. Keep in mind to provide him access to npm.js as well.

I am rwwagner90 on npm

jahrock · 2024-04-11T09:49:48Z

Hi @wozny1989
It seems that the ember-infinity blueprint component has not been refactored yet.
blueprints/infinity-template/files/app/templates/components/infinity-loader.hbs

…omputation

wozny1989 · 2024-04-11T10:07:11Z

Hi @wozny1989 It seems that the ember-infinity blueprint component has not been refactored yet. blueprints/infinity-template/files/app/templates/components/infinity-loader.hbs

@jahrock done 👍

RobbieTheWagner · 2024-04-13T19:02:21Z

Looks like we need to update the node version used to allow these tests to run

wozny1989 · 2024-04-15T08:12:37Z

Looks like we need to update the node version used to allow these tests to run

@RobbieTheWagner I just updated it, let's check

RobbieTheWagner · 2024-04-15T23:25:35Z

@wozny1989 shouldn't we also update the ember-try scenarios to include 4.x versions, and beta and canary and such? I think we should ember-cli-update and do whatever the blueprints do there probably.

wozny1989 · 2024-04-16T09:17:10Z

@RobbieTheWagner Now it should be fine, tested locally as well:

jahrock · 2024-04-16T20:27:13Z

package-lock.json

Hi @wozny1989
I did not expect that package-lock.json and yarn.lock to be present.
Is this on purpose?

@jahrock My bad, just removed package-lock.json 👍

RobbieTheWagner · 2024-04-25T16:49:16Z

@wozny1989 it looks like we need to update node versions. Can you update engines in package.json and our ci.yml to enforce node 18+ please?

wozny1989 · 2024-04-25T16:51:47Z

@wozny1989 it looks like we need to update node versions. Can you update engines in package.json and our ci.yml to enforce node 18+ please?

@RobbieTheWagner Done 👍

RobbieTheWagner · 2024-04-25T17:42:15Z

tests/.eslintrc.js

@@ -1,9 +1,9 @@
 /*eslint-env node*/


I think this file should be deleted, as the root .eslintrc.js handles configuring the test file linting now

Right, I just deleted it

wozny1989 · 2024-04-25T18:17:47Z

@RobbieTheWagner Also I bumped @embroider/test-setup, locally embroider setup are passing 🤔 let's check on CI now

wozny1989 · 2024-04-26T19:29:39Z

On my fork CI have different output, but why? wozny1989#1

migrate to addon v2

wozny1989 · 2024-04-27T17:57:02Z

@RobbieTheWagner Finally I migrated addon to more embroider friendly addon v2, please re-run CI and let's keep finger crossed 🤞 fyi @jahrock

RobbieTheWagner · 2024-04-28T02:10:47Z

A v2 addon is definitely what we want for the future, but this is quite a lot to review now 😅

jahrock · 2024-04-28T10:42:17Z

As I see, many addons get ported from npm to pnpm. Would it make sense to give it a try?

Migrate to pnpm

wozny1989 · 2024-05-06T12:50:03Z

A v2 addon is definitely what we want for the future, but this is quite a lot to review now 😅

@RobbieTheWagner Sorry for that! I had no other idea how to fix the tests on Embroider 😅

As I see, many addons get ported from npm to pnpm. Would it make sense to give it a try?

@jahrock I just migrated to pnpm, please review when you have time 🙈

Bump to Ember 5

wozny1989 · 2024-05-06T13:12:02Z

Finally I bumped to Ember 5, now we have support for Ember >= 3.28.x

jahrock

Works as expected within my ember 4.12 app.
There are no further suggestions from my side.

jahrock · 2024-04-17T12:52:58Z

.github/workflows/ci.yml

-      run: echo "::set-output name=dir::$(yarn cache dir)"
+        try-scenario:
+          - ember-lts-3.24
+          - ember-lts-3.28


Hi @wozny1989
As suggested by @RobbieTheWagner we should test all 4.x LTS versions to ensure complatibility.

Suggested change

- ember-lts-3.28

- ember-lts-3.28

- ember-lts-4.4

- ember-lts-4.8

- ember-lts-4.12

jahrock · 2024-04-19T13:59:23Z

config/ember-try.js

Hi @wozny1989
Let's add the 4.+ LTS versions here as well, so we can verify locally that all versions work as expected.

wozny1989 · 2024-05-08T13:41:47Z

@jahrock Thanks for review, just added scenarios for LTS 4.12 and 5.8 👍

jahrock · 2024-05-08T16:02:14Z

.github/workflows/ci.yml

          - ember-lts-5.4
+          - ember-lts-5.8


I noticed that 5.8 was just released and it's current state is LTS candidate, until 5.9 get released.
Ember released 5.8

IMHO it should be ok to add the next LTS version in advance.

jahrock · 2024-05-10T18:52:24Z

Hi @RobbieTheWagner
what do you think, are we ready to merge?

mansona · 2024-05-15T15:18:58Z

I've noticed a few issues with this but I'll fix it after merging since it's such a large PR to review 🙈

jahrock mentioned this pull request Jan 17, 2024

Will the project be supported for ember 4? #469

Closed

wozny1989 added 2 commits April 11, 2024 12:05

chore: upgrade to Ember 4

572c2d2

fix: using 'content' or defined custom params few times in the same c…

7fe91b3

…omputation

wozny1989 force-pushed the bump-to-Ember-4-x branch from 7d22122 to 7fe91b3 Compare April 11, 2024 10:06

fix: error after change route

9b6956b

chore: update node version on CI

eb4b194

jahrock reviewed Apr 16, 2024

View reviewed changes

chore: update according to Ember blueprints ~4.4.0

ef229ad

wozny1989 force-pushed the bump-to-Ember-4-x branch from 7f09747 to ef229ad Compare April 17, 2024 07:25

jahrock mentioned this pull request Apr 17, 2024

Side effects due to transfer ownership #474

Closed

bump node version

ffe8bfd

RobbieTheWagner reviewed Apr 25, 2024

View reviewed changes

wozny1989 added 2 commits April 25, 2024 19:58

delete redundant .eslintrc.js file

7365e4f

bump @embroider/test-setup

bf0a9d7

wozny1989 added 3 commits April 27, 2024 11:51

migrate yarn to npm

406b09a

migrate to addon v2

de50fa1

Merge pull request #2 from wozny1989/migration-to-addon-v2

3818027

migrate to addon v2

wozny1989 added 2 commits May 6, 2024 14:41

migrate to pnpm

e2a21c2

Merge pull request #4 from wozny1989/migrate-to-pnpm

2ab09ba

Migrate to pnpm

wozny1989 added 2 commits May 6, 2024 15:06

v4.12.3...v5.8.1

d9629f4

Merge pull request #3 from wozny1989/bump-to-ember-5

742f2e3

Bump to Ember 5

wozny1989 requested review from RobbieTheWagner and jahrock May 6, 2024 13:18

wozny1989 changed the title ~~Upgrade to Ember 4~~ Upgrade to Ember 5 May 6, 2024

jahrock approved these changes May 8, 2024

View reviewed changes

add scenarios for ember 4.12 and 5.8

f09d503

jahrock reviewed May 8, 2024

View reviewed changes

Rxbsxn approved these changes May 15, 2024

View reviewed changes

mansona added the breaking label May 15, 2024

mansona merged commit 2493549 into adopted-ember-addons:master May 15, 2024
14 checks passed

mansona changed the title ~~Upgrade to Ember 5~~ Upgrade to Ember 5 and convert to a v2 addon May 15, 2024

This was referenced May 15, 2024

chore: makes it Ember 5 compatible #471

Closed

fix issue with github-changelog #483

Merged

This was referenced May 16, 2024

Prepare Release #480

Merged

Prepare Release jahrock/ember-infinity#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Ember 5 and convert to a v2 addon #470

Upgrade to Ember 5 and convert to a v2 addon #470

wozny1989 commented Jun 3, 2023 •

edited

Loading

ndekeister-us commented Nov 4, 2023 •

edited

Loading

jahrock commented Dec 14, 2023 •

edited

Loading

hhff commented Mar 28, 2024

jahrock commented Apr 2, 2024

hhff commented Apr 2, 2024 via email

jahrock commented Apr 10, 2024

RobbieTheWagner commented Apr 10, 2024

jahrock commented Apr 11, 2024 •

edited

Loading

wozny1989 commented Apr 11, 2024

RobbieTheWagner commented Apr 13, 2024

wozny1989 commented Apr 15, 2024

RobbieTheWagner commented Apr 15, 2024

wozny1989 commented Apr 16, 2024

jahrock Apr 16, 2024 •

edited

Loading

wozny1989 Apr 17, 2024

RobbieTheWagner commented Apr 25, 2024

wozny1989 commented Apr 25, 2024

RobbieTheWagner Apr 25, 2024

wozny1989 Apr 25, 2024

wozny1989 commented Apr 25, 2024 •

edited

Loading

wozny1989 commented Apr 26, 2024

wozny1989 commented Apr 27, 2024

RobbieTheWagner commented Apr 28, 2024

jahrock commented Apr 28, 2024 •

edited

Loading

wozny1989 commented May 6, 2024

wozny1989 commented May 6, 2024

jahrock left a comment

jahrock Apr 17, 2024

jahrock Apr 19, 2024

wozny1989 commented May 8, 2024

jahrock May 8, 2024

jahrock commented May 10, 2024

mansona commented May 15, 2024

-          - ember-lts-3.28
+          - ember-lts-3.28
+          - ember-lts-4.4
+          - ember-lts-4.8
+          - ember-lts-4.12

Upgrade to Ember 5 and convert to a v2 addon #470

Upgrade to Ember 5 and convert to a v2 addon #470

Conversation

wozny1989 commented Jun 3, 2023 • edited Loading

Tasks

ndekeister-us commented Nov 4, 2023 • edited Loading

jahrock commented Dec 14, 2023 • edited Loading

hhff commented Mar 28, 2024

jahrock commented Apr 2, 2024

hhff commented Apr 2, 2024 via email

jahrock commented Apr 10, 2024

RobbieTheWagner commented Apr 10, 2024

jahrock commented Apr 11, 2024 • edited Loading

wozny1989 commented Apr 11, 2024

RobbieTheWagner commented Apr 13, 2024

wozny1989 commented Apr 15, 2024

RobbieTheWagner commented Apr 15, 2024

wozny1989 commented Apr 16, 2024

jahrock Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

wozny1989 Apr 17, 2024

Choose a reason for hiding this comment

RobbieTheWagner commented Apr 25, 2024

wozny1989 commented Apr 25, 2024

RobbieTheWagner Apr 25, 2024

Choose a reason for hiding this comment

wozny1989 Apr 25, 2024

Choose a reason for hiding this comment

wozny1989 commented Apr 25, 2024 • edited Loading

wozny1989 commented Apr 26, 2024

wozny1989 commented Apr 27, 2024

RobbieTheWagner commented Apr 28, 2024

jahrock commented Apr 28, 2024 • edited Loading

wozny1989 commented May 6, 2024

wozny1989 commented May 6, 2024

jahrock left a comment

Choose a reason for hiding this comment

jahrock Apr 17, 2024

Choose a reason for hiding this comment

jahrock Apr 19, 2024

Choose a reason for hiding this comment

wozny1989 commented May 8, 2024

jahrock May 8, 2024

Choose a reason for hiding this comment

jahrock commented May 10, 2024

mansona commented May 15, 2024

wozny1989 commented Jun 3, 2023 •

edited

Loading

ndekeister-us commented Nov 4, 2023 •

edited

Loading

jahrock commented Dec 14, 2023 •

edited

Loading

jahrock commented Apr 11, 2024 •

edited

Loading

jahrock Apr 16, 2024 •

edited

Loading

wozny1989 commented Apr 25, 2024 •

edited

Loading

jahrock commented Apr 28, 2024 •

edited

Loading