Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tracked-maps-and-sets to 3.0.2 #315

Conversation

balinterdi
Copy link

This is to eliminate accessing Ember on the global context which throwsan error in Ember 4.

This is to eliminate accessing Ember on the global context which throws
an error in Ember 4.
@balinterdi
Copy link
Author

@achambers It seems as there is no automated test run to set up. How do you usually decide if a PR is safe enough to be merged? Thank you.

@balinterdi
Copy link
Author

balinterdi commented Mar 21, 2022

This is more complicated than I'd originally thought:

  1. tracked-maps-and-sets drops support for ember-source < 3.23 and node v10 (see here and here), so if this PR gets merged, it should only be released in a major update of this add-on.
  2. I ran the ember-try tests locally and the ones that exercise Ember >= 4 fail because they seem to need ember-auto-import v2. Upgrading to that should probably be done in a separate PR, prior to merging this one. (Though this has nothing to do with this PR)

@achambers
Copy link
Collaborator

@balinterdi Sounds like we should have a Quest issue for making this addon support Ember 4. Also embroider I guess.

As for the tests, they used to be run. I wonder if it's to do with them previously running on Travis. Need to move over to GH Actions or something.

@balinterdi
Copy link
Author

Sounds like we should have a Quest issue for making this addon support Ember 4. Also embroider I guess.

I don't think you need to do anything special with regards to supporting Embroider other than adding the embroider-safe and embroider-optimized scenarios to the ember-try configuration.

As for the tests, they used to be run. I wonder if it's to do with them previously running on Travis. Need to move over to GH Actions or something.

Makes sense, yes, that's what most add-ons do, as far as I can tell.

@SkoebaSteve SkoebaSteve mentioned this pull request Nov 14, 2022
7 tasks
@herzzanu
Copy link
Collaborator

herzzanu commented Mar 9, 2023

Closing in favour of #341

@herzzanu herzzanu closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants