Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test blueprints to new format #758

Closed
Gorzas opened this issue Feb 16, 2021 · 2 comments
Closed

Update test blueprints to new format #758

Gorzas opened this issue Feb 16, 2021 · 2 comments

Comments

@Gorzas
Copy link
Contributor

Gorzas commented Feb 16, 2021

I was working lately with ember-light-table and version 3.24 of Ember. I've found that, when creating a new cell-type, it also creates an integration test file but it's in the old format. I think we should update it using the lately integration tests of Ember.

I'll open a PR as soon as possible so you can see an example of what I'm talking about.

Gorzas added a commit to Gorzas/ember-light-table that referenced this issue Feb 16, 2021
@Gorzas
Copy link
Contributor Author

Gorzas commented Feb 16, 2021

If somebody could take a look to the changes, I can actually update the rest of the blueprints :).

@Gorzas
Copy link
Contributor Author

Gorzas commented Jul 13, 2022

Thanks @rwwagner90 for the merge! I'll close this ticket if no more work is needed 😄

@Gorzas Gorzas closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant