Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of fixes (about damn time!) #163

Merged
merged 6 commits into from
Sep 7, 2016
Merged

Lots of fixes (about damn time!) #163

merged 6 commits into from
Sep 7, 2016

Conversation

offirgolan
Copy link
Collaborator

Proposed Changes:

  • Autoprefix addon.css (until PostCSS is up and running) + install ember-cli-autoprefixer to prefix demo page CSS
  • Pass table instance + rawValue to custom cell component
  • Use style instead of soon deprecated width attribute
  • Remove readOnly from value so it can be modified
  • Column resizer now applies width to table rows on mouseUp instead of on mouseMove
    • I noticed a good amount of performance hits when the column width would be modified on mouseMove

@offirgolan
Lots of changes / fixes
f9c3e1c
@offirgolan
Fix test cases
a086f85
@offirgolan
Pass rawValue to custom component
36f29b2
@offirgolan
Remove readOnly from value
0c22b89
@offirgolan
Merge branch 'master' into width-style
76f3787 
* master:
  [FEATURE] `multiSelectRequiresKeyboard` option for toggling row
selection without ctrl/cmd (#160)
  chore(package): update ember-cli-blanket to version 0.9.9 (#162)

# Conflicts:
#	package.json
@offirgolan
Use value
070328a
@offirgolan offirgolan merged commit 5732ad8 into master Sep 7, 2016
This was referenced Sep 7, 2016
Closed
Closed
Open
Closed
Gorzas pushed a commit to Gorzas/ember-light-table that referenced this pull request Sep 8, 2016
@offirgolan @Gorzas
Lots of fixes (about damn time!) (adopted-ember-addons#163)
260bea4
@offirgolan offirgolan deleted the width-style branch November 7, 2016 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@offirgolan