Replace propertyWillChange/propertyDidChange with notifyPropertyChange #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and add polyfill for < Ember 3.1
alexander-alvarez
approved these changes
May 20, 2019
There was a problem hiding this comment.
LGTM! @fran-worley thoughts? For convenience the pollyfill does this https://github.com/rondale-sc/ember-notify-property-change-polyfill/blob/master/vendor/install-notify-property-change-polyfill.js
|
Looks good! - I think we're better updating the methods as @mmadsen2 has done here rather than relying on the polyfill to do it for us. |
👍
fran-worley
added
Ember Deprecation
RobbieTheWagner
added a commit
that referenced
this pull request
Feb 9, 2021
* replace `sendAction` with modern callable methods * make easy jquery fixes * Release v2.0.0-beta.0 * Release v2.0.0-beta.1 * removed jquery * yarn upgrade * Update ember-scrollable * Assert and Test compatibility with LTS 3.4 * Officially drop support for node 4 in package.json * bump vertical-collection to v1.0.0-beta.13 * Replace merge with assign (#673) * bump vertical-collection to v1.0.0-beta.13 * replace merge with assign * ensure ember-scrollable updates when rows are updated (#677) * refactor: Remove sendAction() calls (#686) * release 2.0.0-beta.3 * Replace propertyWillChange/propertyDidChange with notifyPropertyChange and add polyfill for < Ember 3.1 (#692) Fixes #660 * update changelog for 2.x * Update ember-in-viewport, ember-wormhole, move ember-composable-helpers to devDependencies (#693) * move ember composable helpers to dev dependencies and bump version see #524 * bump ember wormhole * add ember lts 3.8 to travis * remove ember-native-dom-helpers testing add-on * update multiple table test from 1-x branch to remove native-dom-helpers add-on * [breaking] rename inViewport closure action to enterViewport paving the way to update ember-in-viewport dependency * fixes infinite loop on onScrolledToBottom * remove unused rows property from lt-infinity * bump ember-in-viewport version and refactor lt-infinity component not to use mixin * make lt-body.inViewport event deprecated in favour of enterViewport and test * Drop node 6 support as end of line Apr 2019 (#698) LGTM! Node 8 it latest Maintenance LTS and will be EOL in December * Bump Ember CLI to 3.8 and update other dependencies (#696) * bump ember cli to lts 3.8 update other dev dependencies also apply some ember add-on blueprint changes * fix handlebar lint errors Note - unsure why 'no-inline-styles' config isn’t being applied. For now I’ve manually disabled the rule in applicable templates * disable js no-observer rule * update eslint-plugin-ember-suave and fix lint errors * upgrade ember-mirage (used for dummy app) * upgrade remaining addons * set minimum supported ember version at 2.18 (#700) see community survey results - https://emberjs.com/ember-community-survey-2019/ * migrate to using lerna-changelog (#697) * update changelog [ci skip] * BREAKING drop support for ember 2.18 (#713) * [BREAKING] drop support for ember 2.18 * fix travis - ember release can fail * as we use the compute helper we need to restore ember-composable-helpers as a dependency (#714) * [BREAKING] fixes #444 #662 converts ES6 native classes to ember objects (#701) This is a breaking change as it converts the new Class() syntax to Class.create(). In addition, the only way I could get these to work was to convert the positional arguments to named args in an options hashes: `new Table(columns, rows)` => `Table.create(columns: columns, rows: rows)` `new Row(content, options)` => `Row.create({ content: })` `new Column(opts)` => `Column.create(opts)` We’ve had to replace the native constructor methods with emberObject init methods as per the official docs which should also fix #699. As a result we’ve removed the Ember 2.12 ‘hacks’ which shouldn’t be an issue as we’ve bumped ember version minimum version to 2.18. * Bump to ember cli 3.12 and update dependencies (#716) * bump addons * update ember cli to 3.12 * drop ember-release from allowed travis failures * use yarn not npm and remove unused ember-cli-changelog * update ember changelog * [ci skip] fix dummy app port following update to ember cli 3.12 see ember-cli/ember-cli#8794 * release v2.0.0-beta.4 * [ci-skip] update changelog for beta 4 release * replace volatile computed properties with native getters (#718) * Add a guard to check if scaffolding cells exist * Always render scaffolding row in table header * Test lt-scaffolding-row * Update ember-scrollable version to jquery-less * bump ember-code-snippet for dummy app * update travis to include recent LTS versions of ember * fix lint issues * bump ember cli to 3.16.1 and fix/ warn easy js lint errors disable other rules * bump dependency addons * [ci skip] bump changelog and yuidoc addons * [ci-skip] update changelog * fix deprecation warning for overridden rowspan cp * remove unsafe style attribute warnings * make compute own helper then drop ember-composable-helpers as dependency * Remove debugging line in compute helper * Drop support to Ember 3.4 and 3.5 Related #739 * add testing for ember 3.20 * bump addons * drop ember-suave eslint to fix travis # Conflicts: # package.json # yarn.lock * [ci-skip] update ember version in readme * v3.16.1...v3.20.0 * drop support for ember <3.12 * drop this.get Co-authored-by: Donald Wasserman <djwasserman@gmail.com> Co-authored-by: Alex Alvarez <dominalexican@gmail.com> Co-authored-by: Gaurav Munjal <gaurav@peeriq.com> Co-authored-by: Fran Worley <frances@safetytoolbox.co.uk> Co-authored-by: Michal Bryxí <michal.bryxi@gmail.com> Co-authored-by: mmadsen2 <mmadsen@foundationsource.com> Co-authored-by: Tomasz Węgrzyn <twgrzyn1@gmail.com> Co-authored-by: Richard Viney <richard@lightspeedgraphics.co.nz> Co-authored-by: gorzas <joseda87@gmail.com>
RobbieTheWagner
added a commit
that referenced
this pull request
Jul 8, 2022
* replace `sendAction` with modern callable methods * make easy jquery fixes * Release v2.0.0-beta.0 * Release v2.0.0-beta.1 * removed jquery * yarn upgrade * Update ember-scrollable * Assert and Test compatibility with LTS 3.4 * Officially drop support for node 4 in package.json * bump vertical-collection to v1.0.0-beta.13 * Replace merge with assign (#673) * bump vertical-collection to v1.0.0-beta.13 * replace merge with assign * ensure ember-scrollable updates when rows are updated (#677) * refactor: Remove sendAction() calls (#686) * release 2.0.0-beta.3 * Replace propertyWillChange/propertyDidChange with notifyPropertyChange and add polyfill for < Ember 3.1 (#692) Fixes #660 * update changelog for 2.x * Update ember-in-viewport, ember-wormhole, move ember-composable-helpers to devDependencies (#693) * move ember composable helpers to dev dependencies and bump version see #524 * bump ember wormhole * add ember lts 3.8 to travis * remove ember-native-dom-helpers testing add-on * update multiple table test from 1-x branch to remove native-dom-helpers add-on * [breaking] rename inViewport closure action to enterViewport paving the way to update ember-in-viewport dependency * fixes infinite loop on onScrolledToBottom * remove unused rows property from lt-infinity * bump ember-in-viewport version and refactor lt-infinity component not to use mixin * make lt-body.inViewport event deprecated in favour of enterViewport and test * Drop node 6 support as end of line Apr 2019 (#698) LGTM! Node 8 it latest Maintenance LTS and will be EOL in December * Bump Ember CLI to 3.8 and update other dependencies (#696) * bump ember cli to lts 3.8 update other dev dependencies also apply some ember add-on blueprint changes * fix handlebar lint errors Note - unsure why 'no-inline-styles' config isn’t being applied. For now I’ve manually disabled the rule in applicable templates * disable js no-observer rule * update eslint-plugin-ember-suave and fix lint errors * upgrade ember-mirage (used for dummy app) * upgrade remaining addons * set minimum supported ember version at 2.18 (#700) see community survey results - https://emberjs.com/ember-community-survey-2019/ * migrate to using lerna-changelog (#697) * update changelog [ci skip] * BREAKING drop support for ember 2.18 (#713) * [BREAKING] drop support for ember 2.18 * fix travis - ember release can fail * as we use the compute helper we need to restore ember-composable-helpers as a dependency (#714) * [BREAKING] fixes #444 #662 converts ES6 native classes to ember objects (#701) This is a breaking change as it converts the new Class() syntax to Class.create(). In addition, the only way I could get these to work was to convert the positional arguments to named args in an options hashes: `new Table(columns, rows)` => `Table.create(columns: columns, rows: rows)` `new Row(content, options)` => `Row.create({ content: })` `new Column(opts)` => `Column.create(opts)` We’ve had to replace the native constructor methods with emberObject init methods as per the official docs which should also fix #699. As a result we’ve removed the Ember 2.12 ‘hacks’ which shouldn’t be an issue as we’ve bumped ember version minimum version to 2.18. * Bump to ember cli 3.12 and update dependencies (#716) * bump addons * update ember cli to 3.12 * drop ember-release from allowed travis failures * use yarn not npm and remove unused ember-cli-changelog * update ember changelog * [ci skip] fix dummy app port following update to ember cli 3.12 see ember-cli/ember-cli#8794 * release v2.0.0-beta.4 * [ci-skip] update changelog for beta 4 release * replace volatile computed properties with native getters (#718) * Add a guard to check if scaffolding cells exist * Always render scaffolding row in table header * Test lt-scaffolding-row * Update ember-scrollable version to jquery-less * bump ember-code-snippet for dummy app * update travis to include recent LTS versions of ember * fix lint issues * bump ember cli to 3.16.1 and fix/ warn easy js lint errors disable other rules * bump dependency addons * [ci skip] bump changelog and yuidoc addons * [ci-skip] update changelog * fix deprecation warning for overridden rowspan cp * remove unsafe style attribute warnings * make compute own helper then drop ember-composable-helpers as dependency * Remove debugging line in compute helper * Drop support to Ember 3.4 and 3.5 Related #739 * add testing for ember 3.20 * correct travis * bump addons * v3.16.1...v3.20.0 * bump ember version to 3.20 * fix travis.yml * fix eslintrc * replace one-way-controls with ember-power-select and ember input * convert to angle bracket syntax * fix ember data deprecations * fix ember-power-select commit * replace actions for fn/on non shared table * replace table-shared mixin with base-table component * convert action to fn for base-table actions * replace remainder of action with on/fn * bump dummy app addons * Drop support to Ember 3.4 and 3.5 Related #739 * add testing for ember 3.20 * bump addons * drop ember-suave eslint to fix travis # Conflicts: # package.json # yarn.lock * [ci-skip] update ember version in readme * v3.16.1...v3.20.0 * drop support for ember <3.12 * drop this.get * Released 3.0.0-beta.0 * ci: Add github actions with embroider test scenarios * build: Drop Ember 3.12 support BREAKING CHANGE: Dropped support for Ember 3.12 * Node 12 * fix: Fix linting errors * ci: Allow embroider tests to fail Tests pass locally but not in when running with GitHub actions * docs: Remove Embroider safe and optimized from readme CI fails in GitHub actions * fix: Change to @faker/fakerjs to fix missing avatars * Revert "fix: Change to @faker/fakerjs to fix missing avatars" @faker/fakerjs requires Node 14. This reverts commit 81ba515. Co-authored-by: Donald Wasserman <djwasserman@gmail.com> Co-authored-by: Alex Alvarez <dominalexican@gmail.com> Co-authored-by: Gaurav Munjal <gaurav@peeriq.com> Co-authored-by: Fran Worley <frances@safetytoolbox.co.uk> Co-authored-by: Michal Bryxí <michal.bryxi@gmail.com> Co-authored-by: mmadsen2 <mmadsen@foundationsource.com> Co-authored-by: Tomasz Węgrzyn <twgrzyn1@gmail.com> Co-authored-by: Richard Viney <richard@lightspeedgraphics.co.nz> Co-authored-by: gorzas <joseda87@gmail.com> Co-authored-by: maxwondercorn <gmartell@pobox.com> Co-authored-by: Robert Wagner <rwwagner90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace propertyWillChange/propertyDidChange with notifyPropertyChange and add polyfill for < Ember 3.1