Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enableSync option, require updating table rows manually #804

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

RobbieTheWagner
Copy link
Member

This requires manually updating the table rows with things like table.addRow when the data changes. This is a breaking change, since before it was possible to keep things in sync with magic two way binding.

This requires manually updating the table rows with things like `table.addRow` when the data changes. This is a breaking change, since before it was possible to keep things in sync with magic two way binding.
@RobbieTheWagner RobbieTheWagner changed the title Remove enableSync option Remove enableSync option, require updating table rows manually Jul 18, 2022
Copy link
Collaborator

@maxwondercorn maxwondercorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a good change. Removes some of the magic and makes app code more explicit/understandable.

@RobbieTheWagner RobbieTheWagner merged commit 3f8839f into master Jul 19, 2022
@RobbieTheWagner RobbieTheWagner deleted the remove-enable-sync branch July 19, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants