[refactor - typescript] object-transforms
#343
Conversation
jfdnc
force-pushed
the
refactor/typescript/object-transforms
branch
2 times, most recently
from
a75ffcf
to
b4032ae
Compare
jfdnc
changed the title
object-transforms
jfdnc
force-pushed
the
refactor/typescript/object-transforms
branch
from
b778731
to
a50c404
Compare
|
@jherdman Thanks for feedback! No worries about time turnaround, I've had a super busy week myself. Had to force push here to resolve I'm Interested in your thoughts on using the |
I'm down for this naming. I left a suggestion above, but I'm also happy to leave it as is too. |
- refactors `object-transforms.js` to `.ts`
- adds `Options` type of `Record<string,string>` to match expected config options object
- `compact` and `without` wrap new shared `includeKeys` fn
- were both doing essentially the same thing, returning new config options with subset of given config options based on some check
- removes unused `only` fn
- existed only in utils test
- minor refactor of `isPresent` for single-line check of emptiness
- adds descriptive jsdoc headers
current `isPresent` function is name-aliasing `@ember-utils#isPresent`, but serves a different functional purpose. Ember's `isPresent` will return `true` for an object with no keys, but the the util function we're exposing as `isPresent` is checking if the given object has properties. given that this is an Ember addon, we should avoid overloading the concept of "present" in the context of an object's property names. - renames `object-transforms#isPresent` to `object-transforms#hasOwnProperties` - updates imports and instances throughout - collapses import of `@ember/utils#isPresent` in `object-transforms#compact`
- destructure `object-transforms` imports at callsites - some util imports were relative paths, some absolute, call all as absolute paths
jfdnc
force-pushed
the
refactor/typescript/object-transforms
branch
from
a50c404
to
4993e3a
Compare
|
@jherdman Feedback squashed into the relevant commits, and tacked on one more commit for the folder restructuring. |
Refactors object-transforms util file to TypeScript with newly defined
Optionstype for configuration options object, includes a couple of cleanup steps described in the commits.