Minor Segment improvements (custom proxy domain and updated snippet) #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jherdman! Is there anything I could do to make the test suite run? And hopefully got a review from yours 馃檹 Thanks a bunch! |
jherdman
approved these changes
May 4, 2022
|
|
||
| // Load Analytics.js with your key, which will automatically | ||
| // load the tools you've enabled for your account. | ||
| // load the tools you've enabled for your account. Boosh! |
There was a problem hiding this comment.
Haha yeah I kept the funny parts
|
Apologies, I'm not getting notifications on this repo for some reason. Thank you for tagging me. I've kicked CI, let's see what happens. |
|
No worries at all! Thanks for this |
|
Many thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 馃憢
Segment is about to ditch Analytics.js Classic and appears to need a most recent version of the snippet https://segment.com/docs/connections/sources/catalog/libraries/website/javascript/upgrade-to-ajs2/ which is the purpose of that PR.
I also took the liberty to add a new option which would allow to use a custom proxy domain: https://segment.com/docs/connections/sources/catalog/libraries/website/javascript/custom-proxy/
Let me know if I can help in any way :)
Thanks!