Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent ember-pikaday from automatically updating values to within a min/max date bounds #593

Conversation

Duder-onomy
Copy link
Contributor

If merged, ember-pikaday will no longer enforce a min/max date restriction.

Original issue: #581

Ember-pikaday was running code in the modifier that would update the value to the min/max date if that value was outside of the min/max date bounds. This code was causing issues as it would update the value in the same loop that the value was read. Creating exceptions.

The readme used to have this text, we are getting rid of this:

- if you set `minDate` or `maxDate` and that causes `value` to be outside the legal range, we adjust `value` and fire `onSelect` to inform you of the change
  • Removes code that forces the 'value' to be within a minDate or maxDate restriction
  • Updates tests
  • Removes mention of this feature from the readme

@Duder-onomy Duder-onomy changed the title fix: Prevent ember-pikaday from forcing values within the min/max date bounds fix: Prevent ember-pikaday from automatically updating values to within a min/max date bounds Jan 30, 2024
@MelSumner
Copy link
Contributor

ok running the test suite now, will do a new (major) release if it all works out.

Copy link
Contributor

@knownasilya knownasilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for resolving this issue!

@MelSumner MelSumner merged commit b0c470b into adopted-ember-addons:master Feb 6, 2024
5 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants