Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triggers deprecations with ember-modifier 3.2.0+ #452

Closed
simonihmig opened this issue Apr 28, 2022 · 0 comments · Fixed by #508
Closed

Triggers deprecations with ember-modifier 3.2.0+ #452

simonihmig opened this issue Apr 28, 2022 · 0 comments · Fixed by #508

Comments

@simonihmig
Copy link
Contributor

ember-modifier 3.2.0 introduced a new modify hook, and added a number of deprecations: https://github.com/ember-modifier/ember-modifier/blob/master/addon/CHANGELOG.md#v320-2022-03-29

These are all triggered by this modifier now.
simonihmig added a commit to ember-bootstrap/ember-bootstrap that referenced this issue Apr 28, 2022
@simonihmig
Ignore deprecations from ember-popper-modifier
a0fe665 
Due to our strict no-deprecations setup this fails CI. See adopted-ember-addons/ember-popper-modifier#452.

Removed the other ignored deprecations, as these were not needed anymore.
@simonihmig simonihmig mentioned this issue Apr 28, 2022
Merged
@st-h st-h mentioned this issue Sep 26, 2022
Merged
@jelhan jelhan mentioned this issue Jan 12, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor to use ember-modifier's modify hook and fix deprecation st-h/ember-popper-modifier
1 participant
@simonihmig