fix: deprecated EmberError #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knownasilya
merged commit 2f7c85f
into
adopted-ember-addons:master
12 of 25 checks passed
|
@knownasilya can you release a new version containing this PR? |
|
Released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The module EmberError has been deprecated since ember 4.12: https://api.emberjs.com/ember/4.12/modules/@ember%2Ferror
Current import of EmberError is causing build fail when using ember-stripe-elements with Ember 5:
This PR replaces the EmberError by following the deprecation guide:
https://deprecations.emberjs.com/v4.x/#toc_deprecate-ember-error
Because EmberError just reexported native Error, this fix should not cause any braking changes